Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebook cell EOL splitting #13574

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Apr 8, 2024

What it does

When opening a notebook with \n line endings on Windows, cell editing wasn't applied to the plugin host, since the EOL splitting used the system EOL instead of being more lenient with the line endings.

This change uses a less strict regex to split the lines to ensure that \n is being correctly split on Windows.

How to test

  1. Open a notebook document that has a code cell that uses Unix-style line endings.
  2. Edit that cell and confirm that the cell content has actually changed on the plugin host (i.e. run the cell and confirm that the runtime behavior is consistent with the code)

Review checklist

Reminder for reviewers

@msujew msujew added OS/Windows issues related to the Windows OS notebook issues related to notebooks labels Apr 8, 2024
@msujew msujew requested a review from jonah-iden April 8, 2024 11:33
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@msujew msujew merged commit 9cadc9d into master Apr 8, 2024
14 checks passed
@msujew msujew deleted the msujew/fix-notebook-cell-eol branch April 8, 2024 14:17
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks OS/Windows issues related to the Windows OS
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants